with_ascii_lowercased zig builtin #7496
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HajagosNorbert
force-pushed
the
ascii-builtins
branch
from
9f102a0 to
1266186
Compare
|
CI was failing on the roc formatter check and on the use of camelCased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please, before you approve, check out the zig code changes, since I'm unsure about handling reference counts. Tests were passing whether I put a referece count decrement statement in the with_ascii_lowercased function or not for the non-unique strings branch, so the
string.decref();is in there quiet arbitrarily.initFromBigStrisn't used anywhere, so I deleted it.The test
with_ascii_lowercased_non_zero_refcounttestincrates/compiler/test_gen/src/gen_str.rsis an attempt at testing the function when the refcount of it's input string is > 1, but I'm not sure if that's what it does actually.